emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: pdumper bootstrap error


From: Eli Zaretskii
Subject: Re: pdumper bootstrap error
Date: Wed, 23 Jan 2019 18:24:36 +0200

> Date: Tue, 22 Jan 2019 23:20:11 +0000
> From: Alan Third <address@hidden>
> Cc: address@hidden, address@hidden, address@hidden
> 
> On Tue, Jan 22, 2019 at 06:49:45PM +0200, Eli Zaretskii wrote:
> > Could you please try the patch below?  It reverts your "cp -f"
> > addition, and instead attempts to avoid the circular dependency that I
> > think is the root cause of all this.
> 
> Unfortunately I’m still seeing this:
> 
> make[3]: Circular bootstrap-emacs <- temacs dependency dropped.

Arguably, a bug in GNU Make.

> and bootstrap-emacs isn’t being updated (although I’ve not managed to
> provoke the fingerprint error yet).
> 
> -rwxr-xr-x  1 alan  staff  7049484 22 Jan 17:11 src/bootstrap-emacs
> -rwxr-xr-x  1 alan  staff  7058044 22 Jan 23:14 src/temacs

Sigh.  Time for more desperate measures, I guess.  Please try the
patch below (it's against the current master, so revert the previous
change before applying).

diff --git a/src/Makefile.in b/src/Makefile.in
index e0b7e3d..4855290 100644
--- a/src/Makefile.in
+++ b/src/Makefile.in
@@ -521,12 +521,12 @@ LIBES = $(LIBS) $(W32_LIBS) $(LIBS_GNUSTEP) $(LIBX_BASE) 
$(LIBIMAGE) \
    $(NOTIFY_LIBS) $(LIB_MATH) $(LIBZ) $(LIBMODULES) $(LIBSYSTEMD_LIBS) \
    $(JSON_LIBS) $(GMP_LIB)
 
-## FORCE it so that admin/unidata can decide whether these files
-## are up-to-date.  Although since charprop depends on bootstrap-emacs,
-## and emacs (which recreates bootstrap-emacs) depends on charprop,
-## in practice this rule was always run anyway.
-$(srcdir)/macuvs.h $(lispsource)/international/charprop.el: \
-  bootstrap-emacs$(EXEEXT) $(bootstrap_pdmp) FORCE
+## FORCE it so that admin/unidata can decide whether this file is
+## up-to-date.  Although since charprop depends on bootstrap-emacs,
+## and emacs depends on charprop, in practice this rule was always run
+## anyway.
+$(lispsource)/international/charprop.el: \
+  FORCE | bootstrap-emacs$(EXEEXT) $(bootstrap_pdmp)
        $(MAKE) -C ../admin/unidata all EMACS="../$(bootstrap_exe)"
 
 ## We require charprop.el to exist before ucs-normalize.el is
@@ -565,7 +565,6 @@ ifeq ($(DUMPING),unexec)
        cp -f $@ bootstrap-emacs$(EXEEXT)
 else
        rm -f $@ && cp -f temacs$(EXEEXT) $@
-       cp -f $@ bootstrap-emacs$(EXEEXT)
 endif
 
 ifeq ($(DUMPING),pdumper)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]