[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: harfbuzz 2f72162: Fix crash in the Cairo build

From: Robert Pluim
Subject: Re: harfbuzz 2f72162: Fix crash in the Cairo build
Date: Fri, 08 Feb 2019 12:46:32 +0100

Eli Zaretskii <address@hidden> writes:

>> From: Robert Pluim <address@hidden>
>> Cc: address@hidden,  address@hidden
>> Date: Fri, 08 Feb 2019 09:01:22 +0100
>> Eli Zaretskii <address@hidden> writes:
>> >
>> > Thanks, this LGTM, and is a significant improvement, IMO.  If no one
>> > objects in a few days, please push.
>> I built this on GNU/Linux with the following configs:
>> ./configure                # This builds xfont.o ftfont.o xftfont.o ftxfont.o
> I wonder why we build both xftfont.o and ftxfont.o, when we only use
> one of them, if my reading of the code is correct.

I did suggest removing ftxfont.o, but you said we had to deprecate it
first. Itʼs easy enough to not build in the HAVE_XFT config.

>> I can cherry-pick this to the harfbuzz branch if you want.
> Thanks, please do.

Will do.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]