emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: harfbuzz 2f72162: Fix crash in the Cairo build


From: Eli Zaretskii
Subject: Re: harfbuzz 2f72162: Fix crash in the Cairo build
Date: Fri, 08 Feb 2019 23:29:38 +0200

> From: Robert Pluim <address@hidden>
> Cc: address@hidden
> Date: Fri, 08 Feb 2019 17:41:02 +0100
> 
> >   #ifdef HAVE_FREETYPE
> >   #ifdef HAVE_XFT
> >     register_font_driver (&xftfont_driver, f);
> >   #else     /* not HAVE_XFT */
> >     register_font_driver (&ftxfont_driver, f);
> >   #endif    /* not HAVE_XFT */
> >   #endif    /* HAVE_FREETYPE */
> >     register_font_driver (&xfont_driver, f);
> >   #endif    /* not USE_CAIRO */
> >
> > Here, xftfont and ftxfont are clearly 2 more-or-less equivalent
> > alternatives, and bot rely on Freetype.  So I don't understand why not
> > having XFT is taken by configure.ac to mean there's no Freetype,
> > either.  Sounds like a mistake, or did I miss something?
> 
> Interesting. Glenn made that change in
> 46dcfee46cb241a0f8e34da679ca8b42e8ee8d46 , but thatʼs quite a while
> ago.
> 
> Like I said, we can change stuff around here, but I think the easiest
> thing to do is just get rid of it.

Is XFT sufficiently widespread these days that we can rely on it being
available on most systems?  If so, I guess it's okay to drop
ftxfont.c.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]