[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Ignore pending_signals when checking for quits.

From: Eli Zaretskii
Subject: Re: [PATCH] Ignore pending_signals when checking for quits.
Date: Sun, 10 Feb 2019 22:15:42 +0200

> From: Philipp Stephani <address@hidden>
> Date: Sun, 10 Feb 2019 20:46:22 +0100
> Cc: Emacs developers <address@hidden>, Philipp Stephani <address@hidden>
> > If the only problem is the name, we could change the name.  Or we
> > could introduce a new function.  But let's first agree about the
> > substance: a well-behaving module should from time to time call
> > process_pending_signals.  Agreed?
> Yes, absolutely. We can't change the name (this would break backwards
> compatibility), but introducing a new function would be fine.
> For should_quit itself, I still think we should make the change in
> this patch. The current code is clearly buggy: it promises to quit but
> doesn't in most cases.

I'm okay with such a change if it will be accompanied by introduction
of that new function and suitable changes to the manual which explains
why they are needed.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]