emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Questionable code in handling of wordend in the regexp engine in reg


From: Eli Zaretskii
Subject: Re: Questionable code in handling of wordend in the regexp engine in regex-emacs.c
Date: Sat, 02 Mar 2019 14:18:00 +0200

> Date: Sat, 2 Mar 2019 11:16:40 +0000
> Cc: address@hidden, address@hidden
> From: Alan Mackenzie <address@hidden>
> 
> On the coding tests, we fail in one of them when bytepos == 1, and the
> first byte in the buffer is 0xa4.  The Lisp call stack at the time is
> 
> Lisp Backtrace:
> "decode-coding-region" (0xc35b5cb0)

Ah, yes.  We should do this to prevent such false alarms:

  eassert (NILP (BVAR (b, enable_multibyte_characters))
           || bytepos >= BUF_Z_BYTE (b)
           || CHAR_HEAD_P (BUF_FETCH_BYTE (b, bytepos)));

IOW, this test is irrelevant in unibyte buffers.

Thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]