[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Scan of regexp mistakes

From: Paul Eggert
Subject: Re: Scan of regexp mistakes
Date: Thu, 7 Mar 2019 09:39:47 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1

On 3/5/19 7:35 AM, Wilson Snyder wrote:
> Paul et al, thanks for this cleanup:
>> * commit 3c94c7bc02fcacb4a101188dddb0c44d53444178
>>   Author:     Paul Eggert <address@hidden>
>>       Fix regular-expression glitches and typos
> This though failed the verilog-mode.el internal tests due to this:
>> -            
>> "\\s-*\\.\\(\\(address@hidden|---]\\|[][]\\|\\\\[()|]\\)+\\)\\s-*(\\(.*\\))\\s-*\\(,\\|)\\s-*;\\)")
>> +            
>> "\\s-*\\.\\(\\(address@hidden|[][]\\|\\\\[()|]\\)+\\)\\s-*(\\(.*\\))\\s-*\\(,\\|)\\s-*;\\)")
> Which removed | from the character class.

Actually, that patch didn't remove | from the character class, since
[|---] matches only "-", as the "|--" in the pattern does not match
anything since "|" comes after "-" in ASCII.

However, I see you adjusted the regular expression later to add | to the
character class in a different way, so I assume it's OK now. (I don't
know Verilog.)

It is a little puzzling that the patch caused the verilog-mode.el
internal tests to fail, since the failure couldn't have been due to this
part of the patch. My guess is that some other part of the patch was the
culprit, but whatever it was I guess you fixed it. Sorry about the glitch.

By the way, is it still important for verilog-mode.el to support XEmacs?
I thought that XEmacs was kind of dead. If we didn't need to cater to
XEmacs's regular-expression bugs we could simplify that regular expression.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]