[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Scan of regexps in emacs

From: Mattias Engdegård
Subject: Re: Scan of regexps in emacs
Date: Mon, 11 Mar 2019 09:51:49 +0100

11 mars 2019 kl. 03.45 skrev Paul Eggert <address@hidden>:
> Mattias Engdegård wrote:
>> Here is a new regexp error scan of the Emacs source tree.
> Thanks. Alan fixed some of them and I installed the attached, which I hope 
> fixes the rest.

Thank you, and it looks good. Maybe one tweak:

--- a/lisp/language/china-util.el
+++ b/lisp/language/china-util.el
@@ -168,4 +168,4 @@ encode-hz-region
              ;; ESC ESC -> ESC
              (delete-char 1)
            (forward-char -1)
-           (if (looking-at iso2022-gb-designation)
+           (if (looking-at "\e\\$A")

What about (regexp-quote iso2022-gb-designation) instead, possibly hoisted?
(Of course the reader then wonders why iso2022-ascii-designation isn't quoted. 
Oh dear.)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]