[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] scratch/new-flex-completion-style 2c75775 2/2: Score,

From: Dmitry Gutov
Subject: Re: [Emacs-diffs] scratch/new-flex-completion-style 2c75775 2/2: Score, sort and annotate flex-style completions according to match tightness
Date: Tue, 12 Mar 2019 00:54:55 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:66.0) Gecko/20100101 Thunderbird/66.0

On 11.03.2019 03:15, Stefan Monnier wrote:
Of course, if we're careful we can try and tune the weighting of the
types of scores so that both scoring have a visible impact, but I have
the impression that it's going to require too careful tuning to be
usable in practice.

While possible, I think in practice it will require using just one combined sorting function, instead of passing the list of completions though several independent sorting functions. Although please feel free to prove me wrong, because I like the list-of-functions approach.

Ah, we could yes.  That's equivalent to using another global var, indeed.
Currently we use global vars (completion-styles and
completion-cycle-threshold) for that purpose, mostly by accident.

Fair enough.

completion-sort-functions, then?

I'm afraid that if we drop the display-sort and use cycle-sort
everywhere, there's going to be a very strong reaction from users not
appreciating the change.  Even more so if the heuristic is poor.

In that case I'd suggest dropping cycle-sort and, for now, keeping display-sort behavior as is. But make additional sorting configurable like we've been discussing, via completion-sort-functions, as well as package/user overrides in completion-category-*.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]