[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's ove

From: Konstantin Kharlamov
Subject: Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line
Date: Sat, 16 Mar 2019 18:42:44 +0300

В Сб, мар 16, 2019 at 3:43 ПП (PM), Eli Zaretskii <address@hidden> написал:
 From: Konstantin Kharlamov <address@hidden>
 Date: Sat, 16 Mar 2019 04:53:13 +0300

 diff --git a/lisp/progmodes/etags.el b/lisp/progmodes/etags.el
 index 05dc7aa1baf..62637414ef8 100644
 --- a/lisp/progmodes/etags.el
 +++ b/lisp/progmodes/etags.el
 @@ -1395,11 +1395,6 @@ etags-goto-tag-location
            (re-search-forward pat nil t)
            (user-error "Rerun etags: `%s' not found in %s"
                        pat buffer-file-name)))
 -    ;; Position point at the right place
- ;; if the search string matched an extra Ctrl-m at the beginning.
 -    (and (eq selective-display t)
 -       (looking-at "\^m")
 -       (forward-char 1))

Did you actually try this change with selective-display in effect?
Because I'm not sure it is correct in that case.


Hmm… I will try a bit later, but the code seems really straightforward:
        1. if current character is ^M, then step forward
        2. step to the beginnig of the line

The 2 undoes 1.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]