[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's ove

From: Eli Zaretskii
Subject: Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line
Date: Mon, 18 Mar 2019 05:34:00 +0200

> Date: Sun, 17 Mar 2019 23:44:28 +0300
> From: Konstantin Kharlamov <address@hidden>
> Cc: address@hidden
> > But that's incorrect: a tag in a tags table always begins at the
> > beginning of a line, so it must be a search anchored at the beginning
> > of the line.  And in selective-display mode ^M counts as the beginning
> > of a line.
> Great, now that we established that part, to reply your question why we 
> don't care about the beginnging of the line let me quote my other mail:
>  > The pattern that this functions searches for determines the tag 
> uniquely. But here's a catch: no programming language creates distinc 
> entities (ones that end up in the tag), based only on trailing space. 
> I.e. "foo()" and " foo() " always refer to the same thing.

I'm not talking about whitespace.  I'm talking about a tags table file
that names a symbol 'foobar', say.  If you search for a tag "bar" and
do not anchor the search at the beginning of a line, you will decide
that "bar" is present on the "foobar" line, although it really isn't.

If we want to solve a problem with variable leading whitespace, we
need a more sophisticated solution that just dropping the anchor.

Or did I miss something?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]