[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's ove
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line |
Date: |
Tue, 19 Mar 2019 08:47:05 +0200 |
> Date: Tue, 19 Mar 2019 00:45:10 +0300
> From: Konstantin Kharlamov <address@hidden>
> Cc: address@hidden
>
> > 1. Why was the amount of whitespace in the tags table different from
> > that in the source file?
>
> It's a bug in anjuta-tags
So if/when that bug is fixed (maybe it's fixed already), there will be
no reason to make changes in etags.el?
> > 3. Why are the issue and you talking about "trailing whitespace",
> > while the difference between Expected and Actual in the issue is
> > in leading whitespace, not trailing whitespace?
>
> Sorry for confusion here, I was imagining: given a string, whitespace
> may "trail" on both sides of it. But I'm not a native speaker.
OK, no problem. I guessed something like that.
> Okay, whatever. I get your position. Though I disagree, but we clearly
> have different priorities here: while I'm focusing on a Emacs user,
> you're focusing on technical correctness.
It's not just technical correctness. etags.el is used for a very
large number of different "languages" (some of them are not
programming languages at all, like HTML), so any syntactic change that
might be a no-brainer for programming languages could break some other
"language" we currently support.
> Can my 1-st patch from the series be merged though?
I will review that soon, please wait for a little bit longer. I'm
somewhat hard-pressed for free time lately. (Or maybe someone else
here could volunteer to review that sooner?)
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line, (continued)
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line, Konstantin Kharlamov, 2019/03/18
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line, Konstantin Kharlamov, 2019/03/18
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line, Eli Zaretskii, 2019/03/18
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line, Konstantin Kharlamov, 2019/03/18
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line, Konstantin Kharlamov, 2019/03/18
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line, Eli Zaretskii, 2019/03/18
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line, Konstantin Kharlamov, 2019/03/18
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line, Konstantin Kharlamov, 2019/03/18
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line, Konstantin Kharlamov, 2019/03/18
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line, Stefan Monnier, 2019/03/18
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line,
Eli Zaretskii <=
[PATCH v2] lisp/progmodes/etags.el clean up code by removing a temporary, Konstantin Kharlamov, 2019/03/19