[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Proposed changes to gnus-dup.el

From: Eric Abrahamsen
Subject: Re: Proposed changes to gnus-dup.el
Date: Mon, 25 Mar 2019 11:15:27 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

On 03/25/19 18:13 PM, Basil L. Contovounesios wrote:
> Lars Ingebrigtsen <address@hidden> writes:
>> "Basil L. Contovounesios" <address@hidden> writes:
>>> +      (unless (or (gnus-data-pseudo-p datum)
>>> +                  (<= (gnus-data-number datum) 0)
>> I'm against using `unless' on complex logic -- many people get confused
>> when reading it in my experience.
> Fair enough.
>> The rest looks OK.
> Thanks.  I will wait a few more days for people to comment and push the
> rest of the patch if there are no serious objections.

If I end up backing out the hash-table changes, will this patch still
apply correctly?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]