[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Regexp error scan (March 26)
From: |
Basil L. Contovounesios |
Subject: |
Re: Regexp error scan (March 26) |
Date: |
Wed, 27 Mar 2019 03:43:11 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Paul Eggert <address@hidden> writes:
> diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
> index bcaa3e4525..e34487de27 100644
> --- a/lisp/erc/erc.el
> +++ b/lisp/erc/erc.el
> @@ -67,6 +67,7 @@
> (load "erc-loaddefs" nil t)
>
> (eval-when-compile (require 'cl-lib))
> +(require 'cl-seq)
> (require 'font-lock)
> (require 'pp)
> (require 'thingatpt)
> @@ -2522,10 +2523,8 @@ erc-lurker-maybe-trim
> non-nil."
> (if erc-lurker-trim-nicks
> (replace-regexp-in-string
> - (format "[%s]"
> - (mapconcat (lambda (char)
> - (regexp-quote (char-to-string char)))
> - erc-lurker-ignore-chars ""))
> + (regexp-opt (cl-delete-duplicates
> + (mapcar #'char-to-string erc-lurker-ignore-chars)))
> "" nick)
> nick))
regexp-opt already deletes duplicates, so you can just:
(regexp-opt (mapcar #'char-to-string erc-lurker-ignore-chars))
Besides, cl-delete-duplicates defaults to eql for equality, so it's a
no-op here anyway.
Thanks,
--
Basil
- Regexp error scan (March 26), Mattias Engdegård, 2019/03/26
- Re: Regexp error scan (March 26), Paul Eggert, 2019/03/26
- Re: Regexp error scan (March 26),
Basil L. Contovounesios <=
- Re: Regexp error scan (March 26), Mattias Engdegård, 2019/03/27
- Re: Regexp error scan (March 26), Andy Moreton, 2019/03/27
- Re: Regexp error scan (March 26), Stefan Monnier, 2019/03/27
- Re: Regexp error scan (March 26), Mattias Engdegård, 2019/03/27
- Re: Regexp error scan (March 26), Stefan Monnier, 2019/03/27
- Re: Regexp error scan (March 26), Noam Postavsky, 2019/03/27
- Re: Regexp error scan (March 26), Mattias Engdegård, 2019/03/27
- Re: Regexp error scan (March 26), Stefan Monnier, 2019/03/27
- Re: Regexp error scan (March 26), Paul Eggert, 2019/03/27
- Re: Regexp error scan (March 26), Damien Collard, 2019/03/27