[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master d43af7b: * lisp/vc/vc.el (vc-diff-mergebase, v

From: Dmitry Gutov
Subject: Re: [Emacs-diffs] master d43af7b: * lisp/vc/vc.el (vc-diff-mergebase, vc-log-mergebase): New commands.
Date: Tue, 2 Apr 2019 02:26:18 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:66.0) Gecko/20100101 Thunderbird/66.0

On 25.03.2019 23:45, Juri Linkov wrote:
+(defun vc-git-mergebase (rev1 &optional rev2)
+  (unless rev2 (setq rev2 "HEAD"))
+  (string-trim-right (vc-git--run-command-string nil "merge-base" rev1 rev2)))

vc-git--rev-parse returns the same kind of value, but trims the string differently. We should use either one of the approaches in both.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]