[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Do you really mean to call `cl--generic-prefill-dispatchers' twice?

From: Stefan Monnier
Subject: Re: Do you really mean to call `cl--generic-prefill-dispatchers' twice?
Date: Thu, 04 Apr 2019 12:04:31 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

> While looking at the diff of commit
> cd1d9e79f74f137511d49eb9b0ae7ba750ba6c3c, I see the following hunk:
> -- 8< ----------------------
> @@ -1205,6 +1209,7 @@ See the full list and their hierarchy in
> `cl--generic-typeof-types'."
>     (cl-call-next-method)))
>  (cl--generic-prefill-dispatchers 0 integer)
> +(cl--generic-prefill-dispatchers 0 cl--generic-generalizer integer)
>  ;;; Dispatch on major mode.
> -- 8< ----------------------
> Why didn't you delete the first call `(cl--generic-prefill-dispatchers
> 0 integer)'?

Either because:
- There are still methods defined in the preloaded packages which do
  dispatch on a first argument that's `integer`.
- I didn't bother to check whether there are still such methods.
I can't remember which.  If you've check that there aren't such methods
left, then we could remove it, indeed.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]