Re: Predicate for true lists

[Basil L. Contovounesios]

"Daniel Colascione" <address@hidden> writes:

>>> --- a/src/fns.c
>>> +++ b/src/fns.c
>>> @@ -5326,6 +5326,12 @@ syms_of_fns (void)
>>>    DEFSYM (Qcursor_in_echo_area, "cursor-in-echo-area");
>>>    DEFSYM (Qwidget_type, "widget-type");
>>>
>>> +  DEFSYM (Qpure, "pure");
>>> +  DEFSYM (Qside_effect_free, "side-effect-free");
>>> +  DEFSYM (Qproper_list_p, "proper-list-p");
>>> +  Fput (Qproper_list_p, Qpure, Qt);
>>> +  Fput (Qproper_list_p, Qside_effect_free, Qt);
>>
>> I think you can set the side-effect-free property to `error-free`, which
>> is stronger.  Other than that, it looks OK (tho I personally find doing it
>> in C to be too painful, so I prefer moving this kind of code to subr.el).
>>
>>> I also attach a second patch which moves the proper-list-p tests to the
>>> correct file following the function's rewriting in C.  WDYT?
>
> I'd also prefer to put new functionality in lisp when possible. We're
> going to get a JIT one day, and when we do, lisp functionality may very
> well end up *faster* than C stuff anyway due to specialization and
> tracing. In the meantime, lisp performance is adequate, and if we can keep
> the C core small, we should.

The function proper-list-p was originally added to subr.el.
My understanding is Paul moved it to fns.c not for a speedup,
but so that other C code could use it[1].

[1: 200195e824]: Move proper-list-p to C
  2018-07-24 16:08:09 -0700
  
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=200195e824befa112459c0afbac7c94aea739573

-- 
Basil