[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Comprehensive JSX support in Emacs

From: Jackson Ray Hamilton
Subject: Re: Comprehensive JSX support in Emacs
Date: Tue, 9 Apr 2019 18:56:00 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

Hi Eli,

I pushed a feature that should allow users to revert to the old behavior (“Add new defcustom js-jsx-indent-level”) and I mentioned it in the commit “* etc/NEWS: Document way to revert to old JSX indentation behavior”.


On 4/9/19 1:12 AM, Eli Zaretskii wrote:
From: Jackson Ray Hamilton <address@hidden>
Date: Mon, 8 Apr 2019 23:06:25 -0700
Cc: address@hidden

I’ve pushed a commit adding a few comments to the code explaining what I
do in syntax-propertize-function and the rest (“Explain reasonings for
JSX syntax support design decisions”).
Thanks.  I've made minor changes in NEWS, but please look into fixing
this one:

   *** Indentation uses 'js-indent-level' instead of 'sgml-basic-offset'.
   It was never really intuitive that JSX indentation would be controlled
   by an SGML variable.  JSX is a syntax extension of JavaScript, so it
   should be indented just like any other expression in JavaScript.  This
   is technically a breaking change, but it will probably align with how
   you would normally expect for this indentation to be controlled, and
   you probably won't need to change your config.

Backward-incompatible changes should have a way of reverting to old
behavior.  If there is such a way already, please mention it in NEWS;
if there isn't, can we add a feature to revert to old behavior?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]