[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 0cef057: * test/lisp/progmodes/python-tests.el: "Fix" failing

From: Michael Albinus
Subject: Re: master 0cef057: * test/lisp/progmodes/python-tests.el: "Fix" failing test
Date: Thu, 11 Apr 2019 10:05:00 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

address@hidden (Stefan Monnier) writes:

Hi Stefan,

>     * test/lisp/progmodes/python-tests.el: "Fix" failing test
>     (python-tests--python-nav-end-of-statement--infloop): Disable.
> --- a/test/lisp/progmodes/python-tests.el
> +++ b/test/lisp/progmodes/python-tests.el
> @@ -5345,13 +5345,23 @@ class SomeClass:
>  (ert-deftest python-tests--python-nav-end-of-statement--infloop ()
>    "Checks that `python-nav-end-of-statement' doesn't infloop in a
>  buffer with overlapping strings."
> +  ;; FIXME: The treatment of strings has changed in the mean time, and the
> +  ;; test below now neither signals an error nor inf-loops.
> +  ;; The description of the problem it's trying to catch is not clear enough
> +  ;; to be able to see if the underlying problem is really fixed, sadly.
> +  ;; E.g. I don't know what is meant by "overlap", really.
> +  (skip-unless nil)

The way to do this is

:tags '(:unstable)

This prevents the test to run via any make target, but the author is
still able to run the test with a proper selector, working on this.

See also .../test/README

Best regards, Michael.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]