[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master 2475687: Improve documentation changes of a rec
Re: [Emacs-diffs] master 2475687: Improve documentation changes of a recent commit
Mon, 15 Apr 2019 19:06:04 +0300
> Cc: address@hidden
> From: Dmitry Gutov <address@hidden>
> Date: Mon, 15 Apr 2019 18:42:50 +0300
> Speaking of routine maintenance, since you're asking for documentation
> changes together with the patches now, it might be worth it to
> standardize the approach more.
I usually convey that through review comments, as much as
"standardize" is attainable when talking about something like our
documentation, which is basically slightly formalized free text.
> It's not like I disagree with the whole commit altogether. That part
> could be improved. But "refer to that other docstring for the
> description of the optional keyword arguments" is something that made
> sense to me. Enumerating all the possible return types in just one place
> is another thing.
I cannot convince you, but I do feel that my change was for the
better. Just trust me on that, OK?