[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Renaming non-X x_* identifiers

From: Stefan Monnier
Subject: Re: [PATCH] Renaming non-X x_* identifiers
Date: Tue, 16 Apr 2019 08:55:38 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

>> BTW, instead of setting those hook function slots to NULL in
>> text-terminals and then test for non-NULL-ness before calling them,
>> can't we set them to `the_ignore_function`, which we could implement as
>> a vararg function which does nothing?
> I thought about that, but calling an empty function would add a small
> inefficiency, significantly larger than just a test against NULL.

I doubt efficiency at those places in the code would ever be
noticeable ;-)

I was thinking about it from the point of the view of maintenance rather
than efficiency: it removes the need to know which slots might be NULL
(and hence require a test) and which not, so it should simplify
the code.

Anyway, either way is fine, of course,


reply via email to

[Prev in Thread] Current Thread [Next in Thread]