[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Renaming non-X x_* identifiers

From: Alex Gramiak
Subject: Re: [PATCH] Renaming non-X x_* identifiers
Date: Tue, 16 Apr 2019 10:24:13 -0600
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)

Eli Zaretskii <address@hidden> writes:

> So I think we should do the same with get_focus_frame hook as well.

Right, done.

As for the comments, since we now check all of them in the generic code,
I don't think there's a whole lot to do. I have the following comment;
do you think it's sufficient?

  /* Multi-frame and mouse support hooks.  */

  /* Graphical window systems are expected to define all of the
     following hooks with the possible exception of:

   * query_colors
   * activate_menubar_hook
   * change_tool_bar_height_hook
   * set_bitmap_icon_hook
   * buffer_flipping_unblocked_hook


I also added a couple missing comments to query_frame_background_color
and implicit_set_name_hook:

  /* This hook is called to store the frame's background color into
     BGCOLOR.  */

  /* This hook is called to set the name of the GUI window by redisplay
     unless another name was explicitly requested.  */

reply via email to

[Prev in Thread] Current Thread [Next in Thread]