|
From: | Paul Eggert |
Subject: | Re: master b3a12c6: Improve XDG_RUNTIME_DIR diagnostic |
Date: | Sat, 20 Apr 2019 11:51:51 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
Glenn Morris wrote:
commit b3a12c62c9085171866256f00dada4326a4a3084[...]+ int sockdirnamelen = snprintf (sockdirname, sizeof sockdirname, + "/run/user/%"PRIuMAX, id);Is it really worth hard-coding assumptions about the base value of XDG_RUNTIME_DIR in emacsclient? It's a variable, after all.
Although XDG_RUNTIME_DIR is nominally a variable, I don't know of any platform where it exists with a value that is not /run/user/USERID (or perhaps some subdirectory of that). If we discover platforms that do things differently we can generalize the code. In the meantime the patch should be an improvement over what we had earlier - at least, it was an improvement in my little tests.
[Prev in Thread] | Current Thread | [Next in Thread] |