[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master f257a0a: * src/xdisp.c: Only check FRAME_RIF fo

From: Alex Gramiak
Subject: Re: [Emacs-diffs] master f257a0a: * src/xdisp.c: Only check FRAME_RIF for graphical frames
Date: Sun, 28 Apr 2019 21:28:47 -0600
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)

Stefan Monnier <address@hidden> writes:

>> -              if (FRAME_RIF (f)->clear_under_internal_border)
>> +              if (FRAME_WINDOW_P (f)
>> +                  && FRAME_RIF (f)->clear_under_internal_border)
> Wouldn't testing FRAME_RIF(f) instead of FRAME_WINDOW_P(f) make
> more sense?  At least, it would not rely on the fact that FRAME_RIF(f)
> is supposedly non-NULL when FRAME_WINDOW_P(f) is true.
> It'd make the code more "obviously safe".

I thought about that, but this way is more consistent with how the other
RIF procedures are called in xdisp.c (surrounded by a FRAME_WINDOW_P
check somewhere up the chain).

I don't have much of a preference, though; Eli, which would you prefer?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]