[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fill column indicator functionality

From: Ergus
Subject: Re: Fill column indicator functionality
Date: Fri, 3 May 2019 18:18:56 +0200
User-agent: NeoMutt/20180716

I agree, but I added the -face because someone highlighted in another
mail that there was already a symbol called fill-column.

So what should I do then?? Any way there are plenty of symbols ending in
-face... So I thought is was a "relaxed" requirement.

On Fri, May 03, 2019 at 03:14:50PM +0100, Basil L. Contovounesios wrote:
Eli Zaretskii <address@hidden> writes:

Date: Wed, 1 May 2019 13:08:08 +0200
From: Ergus <address@hidden>
Cc: address@hidden

address@hidden fill-column-face

This face should be indexed, use @vindex for that.


+;; Definition stolen from display-line-numbers.
+(defface fill-column-face
+  '((t :inherit (shadow default)))
+  "Face for displaying fill column indicator line.
I'd drop the "line" part.  You allude to the shape of the indicator
character, but it doesn't have to look like a line, and using "line"
is confusing here.

I'm not sure how closely this convention is followed in new code, but
FWIW the defface docs under (info "(elisp) Defining Faces") say:

-- Macro: defface face spec doc [keyword value]...
    This macro declares FACE as a named face whose default face spec is
    given by SPEC.  You should not quote the symbol FACE, and it should
    not end in ???-face??? (that would be redundant).



reply via email to

[Prev in Thread] Current Thread [Next in Thread]