[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Towards a cleaner build: arc-mode

From: Lars Ingebrigtsen
Subject: Re: Towards a cleaner build: arc-mode
Date: Sat, 18 May 2019 08:00:38 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Eli Zaretskii <address@hidden> writes:

> Sorry, that's not what I meant.  (I guess I've misunderstood what you
> were asking about, and thus my "juggling" was misinterpreted.)  I
> meant to do this instead:
>   (defun insert-unibyte (&rest args)
>     "Like insert but don't make unibyte string and eight-bit char multibyte."
>     (dolist (elt args)
>       (if (integerp elt)
>         (insert (if (< elt 128) elt (decode-char 'eight-bit elt)))
>       (insert elt))))
> IOW, just lose the string-to-multibyte part, as I don't think it's
> needed nowadays, since 'insert' already does the equivalent of
> string-to-multibyte when needed.  The warning we want to get rid off
> is about string-to-multibyte, not about decode-char, right?

Ah, right, yes.

But that's unfortunately the part I'm not able to test since the
commands that use that path don't actually work...

But I think you're right -- the two functions that insert a string
insert only encoded strings (with some binary stuff afterwards), so I
think that change should be safe.

(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

reply via email to

[Prev in Thread] Current Thread [Next in Thread]