[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master updated (05b7953 -> b2b1ccb)

From: Paul Eggert
Subject: Re: master updated (05b7953 -> b2b1ccb)
Date: Mon, 20 May 2019 13:34:49 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

On 5/20/19 11:47 AM, Alex Gramiak wrote:
Hmm, this is weird: the warnings seem to be legitimate
(get_per_char_metric can return NULL)

No, the warnings are not legitimate. Those calls to get_per_char_metric occur only when get_char_glyph_code succeeds, and when that happens get_per_char_metric cannot fail.

I wouldn't worry about bogus warnings issued by older instances of GCC, or issued by GCC with non-default build options. There are too many such warnings, and we'd waste time (and clutter up the code, perhaps incorrectly) pacifying them. Just worry about the latest GCC with default build options.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]