[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Simplify Gnus buffer liveness checking and killing

From: Basil L. Contovounesios
Subject: Re: [PATCH] Simplify Gnus buffer liveness checking and killing
Date: Mon, 20 May 2019 23:19:39 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Attachment: 0001-Simplify-Gnus-buffer-liveness-checking-and-killing.patch
Description: Text Data

Eric Abrahamsen <address@hidden> writes:

> "Basil L. Contovounesios" <address@hidden> writes:
>> There seems to be overlap in the implementations and usage of
>> gnus-buffer-exists-p and gnus-buffer-live-p, as well as of gnus-buffers
>> and gnus-prune-buffers.
>> The attached patch removes gnus-buffer-exists-p in favour of a modified
>> gnus-buffer-live-p, aliases gnus-prune-buffers to a simplified
>> gnus-buffers, and simplifies several call sites pertaining to buffer
>> liveness checking and killing.  WDYT?
> I've been running this most of today; nothing terrible has happened so
> far.

Thanks for testing.

> Can I suggest adding `gnus-buffer-exists-p' back in as a
> `define-obsolete-function-alias' for `gnus-buffer-live-p'?

Drats, I was hoping to get away with that one. ;)

> I assume that will work for macros.

Yes, so long as the macroexpansion sites are recompiled.

> Anyway, it would just be nicer for people who, ahem, have external
> packages that were using that function.

I could have sworn I checked GNU ELPA before removing it...  Probably
got mixed up with some other branch I had on the back-burner, sorry.

Updated patch attached.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]