Re: Add support for base64url variant

[Eli Zaretskii]

> From: Pierre Téchoueyres <address@hidden>
> Date: Wed, 22 May 2019 00:32:19 +0200
> 
> +                                 NILP(no_pad), !NILP(url_variant),

Please leave one blank between the name of a macro or function and the
following opening parenthesis.

> +       if (pad) {
> +         *e++ = '=';
> +         *e++ = '=';
> +       }

This is not our style of writing blocks in braces.  We use this style:

   if (pad)
     {
       *e++ = '=';
       ...

> +       *e++ = b64_value_to_char[value];
> +       if (pad) {
> +         *e++ = '=';
> +       }

Likewise.

I'd suggest to call the new argument base64url or somesuch, since
this is trhe official name.