[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Add support for base64url variant

From: Pierre Téchoueyres
Subject: Re: Add support for base64url variant
Date: Mon, 27 May 2019 22:30:14 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.50 (gnu/linux)

Eli Zaretskii <address@hidden> writes:

>> From: address@hidden (Pierre Téchoueyres)
>> Cc: address@hidden
>> Date: Thu, 23 May 2019 21:37:01 +0200
>> > I'd suggest to call the new argument base64url or somesuch, since
>> > this is trhe official name.
>> >
>> You mean in replacement of url_variant or b64_value_to_char ?
> The former.
>> How should I send new versions of the patch ? As a full patch in
>> attachment like previously ?
> Yes.  And please include the log messages (in the ChangeLog style).
You'll find two patches attached.
First one contains requested changes and, hoppefully, a valid Changelog

Attachment: 0001-Add-support-for-base64url-variant-with-parameters.patch
Description: with parameters

The second patch contains an reworked version wich instead of adding
many parameters to base64-encode-region (resp. base64-encode-string)
function create the base64url-encode-region
(resp. base64url-encode-string) function. Documentation and tests are
also updated consequently.

Attachment: 0001-Add-support-for-base64url-variant-with-new-functions.patch
Description: new functions

Tell me what you thing is the way to go.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]