[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Towards a cleaner build

From: Noam Postavsky
Subject: Re: Towards a cleaner build
Date: Mon, 27 May 2019 19:03:56 -0400

On Fri, 17 May 2019 at 10:37, Lars Ingebrigtsen <address@hidden> wrote:
> I just went ahead and finished up the two "automatic" warning
> suppression things that Noam mentioned: With the following patch, a
> function that has an advertised calling convention that calls itself
> will check the real arglist when issuing warnings, and obsolete
> functions that calls other obsolete functions won't issue any warnings.
> I've built an Emacs (after rm-ing lisp/*.elc) and things seem to work

> @@ -92,6 +92,11 @@ defun-declarations-alist
>                     (list 'quote f) (list 'quote arglist) (list 'quote 
> when))))
>     (list 'obsolete
>           #'(lambda (f _args new-name when)
> +             ;; Record obsolete info immediately so that we know that
> +             ;; we're compiling an obsolete function and can avoid
> +             ;; giving warnings about calls to obsolete functions from
> +             ;; this function.
> +             (make-obsolete f new-name when)
>               (list 'make-obsolete
>                     (list 'quote f) (list 'quote new-name) (list 'quote 
> when))))

I think this could have the unwanted side-effect of "polluting" the
Emacs session which runs the compiler with the obsolete function info
from the files it's compiling. If we have with-suppressed-warnings
then this auto suppression could be implemented in a more obvious way
by wrapping the output code in (with-suppressed-warnings ...). And
perhaps as Stefan suggests, we'll find the automation isn't really
worth the trouble anyway.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]