[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fixing some warnings in emacs-26

From: Juanma Barranquero
Subject: Re: Fixing some warnings in emacs-26
Date: Sat, 8 Jun 2019 09:07:43 +0200

> LGTM, thanks.  However, please install those on master, as I'd like to
> minimize changes on the release branch: we will start the pretest of
> Emacs 26.3 soon.


> Instead of the arbitrary value of 20, I'd prefer using sizeof for the
> actual text (which should probably be assigned to a variable, to avoid
> mentioning the same text twice).


Though I wanted to avoid adding complexity for a string message that's
unlikely to change. Also, addpm.c already contains a few instances of
hardcoded constants:

      /* Ensure there is enough room for "...\GNU Emacs\Emacs.lnk".  */
      if (strlen (start_folder) < (MAX_PATH - 20))


      char add_item[MAX_PATH*2 + 100];


reply via email to

[Prev in Thread] Current Thread [Next in Thread]