emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Docstring of make-symbolic-link


From: Paul Eggert
Subject: Re: Docstring of make-symbolic-link
Date: Tue, 11 Jun 2019 08:50:21 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0

On 6/11/19 7:22 AM, Eli Zaretskii wrote:
This appears to be some kind of copy-pasta from add-name-to-file,
which creates a hard link.

Yes, and that's a good thing because hard links and symbolic links are similar here.

We should use "NEWNAME" here, not merely for consistency with add-name-to-file, but also because using "NEWNAME" makes it clearer that it's the thing being created instead of TARGET. It's all too easy to misread "(make-symbolic-link TARGET LINKNAME)" as meaning that TARGET gets created with the contents LINKNAME, which is the opposite of what the function actually does.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]