[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Towards a cleaner build: erc.el

From: Lars Ingebrigtsen
Subject: Re: Towards a cleaner build: erc.el
Date: Thu, 13 Jun 2019 02:04:07 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

In erc-send-input:
erc/erc.el:5462:9:Warning: global/dynamic var `str' lacks a prefix

The problem here is that `str' is in the public calling converion on

(defcustom erc-send-pre-hook nil
  "Hook called first when some text is sent through `erc-send-current-line'.
It gets called with one argument, STRING.

To change the text that will be sent, set the variable `str' which is
used in `erc-send-current-line'.

That's a quite, er, uhm, strange way of doing it, but...  The
traditional way is to offer a filter function that can alter the string.

Would a way forward here be to obsolete this hook variable and add a new
function along those lines?

(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

reply via email to

[Prev in Thread] Current Thread [Next in Thread]