[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Gnus nnir patch for Emacs 26?

From: Eric Abrahamsen
Subject: Re: Gnus nnir patch for Emacs 26?
Date: Fri, 14 Jun 2019 01:18:39 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Eli Zaretskii <address@hidden> writes:

>> From: Eric Abrahamsen <address@hidden>
>> Date: Thu, 13 Jun 2019 15:20:52 -0700
>> > If this patch indeed fixes the problem, it's okay for emacs-26, but
>> > please only add that one line, don't reindent anything and don't
>> > replace lambda with its fancier equivalent.  Just the minimal required
>> > change.
>> Here's a proper commit with a simpler-looking version that doesn't
>> re-indent everything. I've done before-and-after tests and this works
>> just the same. I've also added a do not merge thing following Robert's
>> pointer.
>> How's it look?
> Fine with me, thanks.

Cool, will push tomorrow.

> P.S. I was wondering why we use all those wrappers around
> decode-coding-string instead of calling the latter directly, but since
> you are saying this code will go away in Emacs 27, this is a moot
> point.  I do suggest to look for such trivial wrappers on master and
> eliminate them if any are still there, as a cleanup.

The code in scratch/gnus-decoded will do some of that, since the point
of that branch is to make sure group names are decoded strings as they
enter the system, rather than decoding them as they come out of the
system (ie, as they are presented to the user).

reply via email to

[Prev in Thread] Current Thread [Next in Thread]