[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [elpa] master aa5513d 1/7: excorporate-diary: Always use diary-fancy
Re: [elpa] master aa5513d 1/7: excorporate-diary: Always use diary-fancy-display
Sat, 15 Jun 2019 09:13:47 -0400
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
Stefan Monnier <address@hidden> writes:
>> + (unless (eq diary-display-function 'diary-fancy-display)
>> + (warn (format
>> + (concat "Excorporate diary support needs diary-fancy-display"
>> + " but diary-display-function is currently %S; overriding")
>> + diary-display-function))
>> + (customize-set-variable 'diary-display-function 'diary-fancy-display))
> The warning is good, but I think that unilaterally overriding the user's
> choice is a bad idea.
> For example, it prevents using a tweaked version of `diary-fancy-display`.
Thanks for reviewing. Yeah, I didn't like having to do that but the
stock alternative, diary-simple-display, is broken. Specifically, even
with diary-include-other-diary-files in diary-list-entries-hook,
diary-simple-display doesn't show included entries. Maybe that's
intended behavior for diary-simple-display, but it makes it seem like
Excorporate hasn't done anything (since all its entries are included
I'm not sure how to disallow diary-simple-display but allow tweaked
versions of diary-fancy-display. (Currently I'm also relying on
diary-fancy-display-mode-hook.) I suppose I could just leave the
warning and remove the customize-set-variable call. I'll think about it
for the next release.
Maybe I should also file a bug about diary-simple-display not showing