[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Towards a cleaner build: feedmail

From: Lars Ingebrigtsen
Subject: Re: Towards a cleaner build: feedmail
Date: Sat, 15 Jun 2019 17:28:13 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Eli Zaretskii <address@hidden> writes:

> Sounds like this bug was caused by converting feedmail to
> lexical-binding?

Hm...  I don't think so: It's funcalling the wrong symbol, in essence

(funcall (let ((helper 'message)) 'helper))

I think the fix is pretty trivial:

diff --git a/lisp/mail/feedmail.el b/lisp/mail/feedmail.el
index 943bdd8851..6f50c3e4ed 100644
--- a/lisp/mail/feedmail.el
+++ b/lisp/mail/feedmail.el
@@ -2170,7 +2170,7 @@ feedmail-queue-send-edit-prompt-inner
          (if (= user-sez help-char)
               ;; FIXME: This seems to want to refer to the `helper' argument,
               ;; but it's quoted so the `helper' arg ends up unused!
-             (setq answer '(^ . helper))
+             (setq answer (cons '^ helper))
            (if (or (eq user-sez ?\C-m) (eq user-sez ?\C-j) (eq user-sez ?y))
                (setq user-sez d-char))
            ;; these char-to-int things are because of some

but it would be nice to have someone confirm that this analysis is right
before doing anything.

(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

reply via email to

[Prev in Thread] Current Thread [Next in Thread]