Re: Enhance seq-min and seq-max

[Nicolas Petton]

Michael Heerdegen <address@hidden> writes:

>> I left some comments below.
>>
>> > +  (if predicate
>>          ^^^^^^^^^
>> What if `predicate' is nil but `key' is non-nil?
>
> Then it does nonsense.  Ok, we get one more case.

If it's documented, I'm fine with it.

> I wonder if I should rather give one general definition in the
> function body and handle the four cases (KEY/PREDICATE given/not
> given) in a compiler macro.  Then in compiled code there would be no
> runtime tests and it would be optimized for the respective case.

As you wish, but depending on what exactly you have in mind, it might be
better not to do it, so that `seq-min' and `seq-max' can still easily be
overwritten for custom seq types.

Nico

signature.asc
Description: PGP signature