[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Image transformations

From: Alan Third
Subject: Re: Image transformations
Date: Mon, 17 Jun 2019 22:13:32 +0100
User-agent: Mutt/1.12.0 (2019-05-25)

On Sun, Jun 16, 2019 at 07:34:53PM +0300, Eli Zaretskii wrote:
> > Date: Sun, 16 Jun 2019 16:22:59 +0100
> > From: Alan Third <address@hidden>
> > Cc: address@hidden
> > 
> > In another part of this thread you pointed out that crop and image
> > slices are doing basically the same thing. I hadn’t realised that.
> > Given that that’s the case, I think we should just get rid of the crop
> > function.
> I agree, but please make sure the slices are indeed a 100% replacement
> (I cannot yet do that because I don't have a working :crop support to
> try it).

As far as I can tell they are perhaps a 90% replacement, the only real
difference is that the interactive keybinds from image.el don’t work
(r for rotate, + for scale up, etc.). They can probably be made to
work, but to be honest I’m not sure it matters. If someone is cropping
an image I can’t think of any use cases where they’d want to then
provide the user the ability to play with that image interactively.

Perhaps I’m just not imaginative enough.

> > +       [x]   [m11 m12 tx]   [x']
> > +       [y] X [m21 m22 ty] = [y']
> > +       [1]   [  0   0  1]   [1 ]
> Either we use a column vector, and it should be on the right of the
> matrix; or we use a row vector, in which case it should be on the
> left.  Which of these is the case?

It is the former. I fixed it before pushing.

> > diff --git a/test/manual/image-transforms-tests.el 
> > b/test/manual/image-transforms-tests.el
> > new file mode 100644
> > index 0000000000..d601b9397e
> > --- /dev/null
> > +++ b/test/manual/image-transforms-tests.el
> This is great, but Windows only supports displaying images from files,
> so we will have to write these specs to files, and then display them.

That’s unfortunate. Patch attached.
Alan Third

Attachment: 0001-Move-inline-SVG-images-to-separate-files.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]