[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: `message' not outputting the newline "atomically"

From: Eli Zaretskii
Subject: Re: `message' not outputting the newline "atomically"
Date: Tue, 25 Jun 2019 19:06:12 +0300

> From: Paul Eggert <address@hidden>
> Date: Mon, 24 Jun 2019 15:03:01 -0700
> Cc: Daniele Nicolodi <address@hidden>, address@hidden
> On 6/24/19 2:33 PM, Lars Ingebrigtsen wrote:
> > the code also calls code_convert_string, so I thought one
> > more xmalloc didn't make much difference.
> If code_convert_string could cause an infloop when reporting 
> low-on-memory messages, then we should fix that infloop too. In the 
> meantime we shouldn't make things worse by doing yet another heap 
> allocation.

It is very unusual for code_convert_string to allocate memory;
normally it just reuses a buffer that was allocated at startup.

So I think we don't normally have any heap allocations in this use
case -- or didn't have until now.  I agree that we should avoid that.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]