[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5] Enable xwidgets on macOS
From: |
Alan Third |
Subject: |
Re: [PATCH v5] Enable xwidgets on macOS |
Date: |
Fri, 19 Jul 2019 20:17:18 +0100 |
User-agent: |
Mutt/1.12.0 (2019-05-25) |
Hi, thanks for continuing to work on this. Is there still work to be
done before we push to master?
Before that it would be helpful if you could add a commit message as
described in CONTRIBUTE. To get you started here’s what I added to a
previous patch (Savannah appears to be down):
https://github.com/emacs-mirror/emacs/commit/4f5c264a412c4187d86f5e43218d6ffb7de1bf76
although I think it should have a ‘Co-authored by:’ line for the
original author whose name escapes me just now.
> +++ b/src/nsxwidget.h
> @@ -0,0 +1,80 @@
> +/* Header for NS Cocoa part of xwidget and webkit widget.
> +
> +Copyright (C) 2011-2017 Free Software Foundation, Inc.
^^^^^^^^^
I think that should just be this year as it’s a new file.
> +++ b/src/nsxwidget.m
> @@ -0,0 +1,611 @@
> +/* NS Cocoa part implementation of xwidget and webkit widget.
> +
> +Copyright (C) 1989, 1992-1994, 2005-2006, 2008-2017 Free Software
> +Foundation, Inc.
Same here.
> +#if 0
> +/* Non ARC - just to check lifecycle. */
> +- (void)dealloc
> +{
> + NSLog (@"XwWebView dealloc");
> + [super dealloc];
> +}
> +#endif
Is this code just for testing and should be removed?
I don’t see anything wrong with the patch other than some unclear
English in the comments. I think we’d be best to push to master in the
hopes that people will try it out and report any bugs; nobody but me
seems to have tried the branch I created before.
--
Alan Third
- [PATCH v4] Enable xwidgets on macOS, Sungbin Jo, 2019/07/18
- [PATCH v5] Enable xwidgets on macOS, Sungbin Jo, 2019/07/19
- Re: [PATCH v5] Enable xwidgets on macOS,
Alan Third <=
- Re: [PATCH v5] Enable xwidgets on macOS, Eli Zaretskii, 2019/07/20
- Re: [PATCH v5] Enable xwidgets on macOS, 조성빈, 2019/07/23
- Re: [PATCH v5] Enable xwidgets on macOS, 조성빈, 2019/07/25
- Re: [PATCH v5] Enable xwidgets on macOS, Eli Zaretskii, 2019/07/26
- Re: [PATCH v5] Enable xwidgets on macOS, Richard Stallman, 2019/07/26
- Re: [PATCH v5] Enable xwidgets on macOS, Eli Zaretskii, 2019/07/27
- Re: [PATCH v5] Enable xwidgets on macOS, Eli Zaretskii, 2019/07/27
- Re: [PATCH v5] Enable xwidgets on macOS, 조성빈, 2019/07/27
- Re: [PATCH v5] Enable xwidgets on macOS, Eli Zaretskii, 2019/07/27