emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Improve Gravatar support


From: Basil L. Contovounesios
Subject: Re: [PATCH] Improve Gravatar support
Date: Tue, 23 Jul 2019 10:18:10 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Andy Moreton <address@hidden> writes:

> On Mon 22 Jul 2019, Basil L. Contovounesios wrote:
>
>> Andy Moreton <address@hidden> writes:
>>
>>> It is better to put each in a separate patch, to ease later bisection if
>>> needed.
>>
>> More often I see reviewers express the opposite feeling here, but since
>> I don't personally mind and you asked so nicely:
>
> Thanks. A series of simple patches is easier to review than a longer
> patch that mixes several logical changes, and bisection is more likely
> to return a useful answer.

Sure, but the preferred granularity is subjective.

> The patches look good to me,

Thanks,

-- 
Basil



reply via email to

[Prev in Thread] Current Thread [Next in Thread]