[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Changes in GC and in pure space

From: Paul Eggert
Subject: Changes in GC and in pure space
Date: Thu, 5 Sep 2019 00:04:32 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

Stefan Monnier wrote:
I'm not sure if replacing INLINE with nothing at all would lead to much
worse code.

I assume you meant "'static'" instead of "nothing at all" - we couldn't replace INLINE with nothing at all, as that would cause duplicate function definitions.

I did try 'static' (actually, 'static ATTRIBUTE_UNUSED' to pacify gcc -Wunused-function) and found that it improved performance of 'make compile-always' by 8% on my old work desktop and by 6% on a newer machine, so I installed the attached patch. Using 'static' also shrank the text size of the executable by 4.5%, for what that's worth. 'static' also has the virtue of being simpler. At some point we can remove the EMACS_EXTERN_INLINE code as I expect it won't be needed.

Attachment: 0001-Use-plain-static-for-Emacs-C-inline-functions.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]