emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Warning in replace.el


From: Lars Ingebrigtsen
Subject: Warning in replace.el
Date: Tue, 17 Sep 2019 14:01:53 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Compiling Emacs now, I get

In perform-replace:
replace.el:2714:35:Warning: assignment to free variable
    `last-replacement-replaced'

It's this code:

                                  search-string-replaced search-string
                                  last-replacement-replaced last-replacement
                                  last-was-act-and-show nil)

But setting last-replacement-replaced is the only place this variable is
mentioned.

Tino?  It's from this commit:

commit 30c4f35a6fc8a6507930923766c3126ac1c2063f
Author: Tino Calancha <address@hidden>
Date:   Mon Sep 9 08:21:18 2019 +0200

    query-replace-regexp undo: Update next-replacement after undo
    
    * lisp/replace.el (perform-replace):
    Rename the local binding to not shadow next-replacement.
    Update next-replacement after undo (Bug#37287).
    
    * test/lisp/replace-tests.el (query-replace-undo-bug37287): Add test.
    (query-replace-undo-bug37073): Tweak this test.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




reply via email to

[Prev in Thread] Current Thread [Next in Thread]