[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: A project-files implementation for Git projects

From: Dmitry Gutov
Subject: Re: A project-files implementation for Git projects
Date: Mon, 30 Sep 2019 03:09:19 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

Hi Tassilo,

On 27.09.2019 19:17, Tassilo Horn wrote:

I have to admit that I've lost track over what we're actually trying to
do exactly.  My main motivation was just to get a faster project-files
implementation for the Git repo I have at work.  I've now fixed that on
my end using a simple caching approach which is good enough for me ATM.

I'm attaching a working patch that will probably need tweaks later. I'm not sure how to handle attribution best. If you like it, you can simply commit it under your name (up to now, I've mostly done the rearranging and some minor tweaks).

So I think that your current idea is to:

- No general VC list-files operation since we can come up with good
   versions just for Git and Hg anyway.  Fine with me.

Great. I think we should start with that that either way. And when some other application arises that could use a VC 'ls-files' command we should see whether we can extract something that satisfies both. Maybe the minimum supported Git version will make it easier for us too then.

- I'm not sure if we're on the same board when it comes to ignores.

If you want me to implement something I fear you have to explain the
ignore story again.  I don't know what you imply by renaming the
parameter from EXTRA-IGNORES to ALL-IGNORES.  Do you mean that the
patterns in .{git,hg}ignore (and $XDG_CONFIG_HOME/git/ignore,
$GIT_DIR/info/exclude) should be part of the ALL-IGNORES list (in
addition to project-vc-ignores) and parsed from those files?

Good point, I forgot about those (and also about per-directory gitignore files). ALL-IGNORES would be a nice semantics for a VC 'ls-files' command, but if we're not doing that now, we don't have to try to fit that approach.

Still, there could be a performance problem with outputting all ignored files and then parsing out only a part of them. Could you try the new feature with a test repository from https://debbugs.gnu.org/cgi/bugreport.cgi?bug=22481?

3 files in the case of Git and handling 3 ignore syntaxes (regexp, glob,
rootglob) in the case of Hg doesn't sound too appealing to me.

Speaking of syntaxes, I was curious which one is used by Mercurial's --exclude. But it seems to accept globs okay, including ones rooted with './'.

Attachment: vc-list-files.diff
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]