emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: eieio-base patch to support EDE project loading


From: Stefan Monnier
Subject: Re: eieio-base patch to support EDE project loading
Date: Sun, 06 Oct 2019 16:02:15 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

> Patch looks like a good idea to me.  I was worried about overhead of always
> checking and un-autoloading, but this patch seems to deal with that nicely.

Right, I think it's only used in places which should hopefully not be
performance-sensitive.

> The original problem arose when trying to identify the class
> parents.  Perhaps using eieio--full-class-object in eieio-class-parents would
> cast a slightly wider net?

eieio-class-parents is not used internally, so it's not sufficient, but
it's indeed a good idea to make it load the class if needed, so I made
that change as well.

>> Can you test the patch below before I push it?
> It works great.  Thanks for looking into it!

Great, pushed to `master`, thanks,


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]