Re: :extend face attribute at EOB without end-of-line char

[Ergus]

Hi Eli:

Somehow this is related with something we discussed some time ago, about
the fact that we should call extend_face_to_end_of_line in the last line
of the buffer if not empty in some conditions (dfci is active for
example.)

Maybe you remember that we don't have the indicator for the last line,
which somehow we agreed must be corrected. In this case the problem is
the same: the extend_face... function is not called for the latest line
in the buffer but I didn't find a better condition to fix this (I didn't
try very hard either) But probably it just requires to extend a
condition in an if and part of this problem will be fixed (the case for
the last line at least)

There are some conditions in the display_line function to not call
extend_face_to... when the line ends at ZV, fixing this condition we
should be done right?

On Tue, Oct 15, 2019 at 11:27:10AM +0300, Eli Zaretskii wrote:
> > From: Juanma Barranquero <address@hidden>
> > Date: Tue, 15 Oct 2019 10:10:21 +0200
> > Cc: address@hidden, Emacs developers <address@hidden>
> >
> > > OK, but still, we'd need a rationale.
> >
> > I'm not sure what rationale would satisfy you. In my mind, the idea of 
> > extending a face up to the margin of the
> > window seems quite decoupled from whether that line has a newline at the end or 
> > not. It's purely visual. If I'm
> > using a face that extends in all lines, for example, I find weird that it does 
> > or does not extend in the last one
> > depending of a newline. (Again: I agree that's how it is defined now, I'm not 
> > questioning that.)
>
> Face extension is only a factor when it ends on the next line,
> i.e. "covers" the newline that ends the line.  When there's no newline
> at EOB, the face ends with the last character on the line, so IMO it
> makes no sense to extend it, because what would such an extension
> indicate?  When there's a newline, extending the face indicates that
> the newline (which is otherwise invisible) is "covered" by the face.