emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Tab bar tabs landed on master


From: Eli Zaretskii
Subject: Re: Tab bar tabs landed on master
Date: Fri, 15 Nov 2019 10:21:23 +0200

> From: Juri Linkov <address@hidden>
> Cc: address@hidden,  address@hidden
> Date: Fri, 15 Nov 2019 01:37:51 +0200
> 
> > diff --git a/src/term.c b/src/term.c
> > index 6420105..b60484e 100644
> > --- a/src/term.c
> > +++ b/src/term.c
> > @@ -2568,6 +2568,14 @@ handle_one_term_event (struct tty_display_info *tty, 
> > Gpm_Event *event,
> >    else {
> >      f->mouse_moved = 0;
> >      term_mouse_click (&ie, event, f);
> > +    if (tty_handle_tab_bar_click (f, event->x, event->y,
> > +                             (ie.modifiers & down_modifier) != 0, &ie))
> > +      {
> > +   /* tty_handle_tab_bar_click stores 2 events in the event
> > +      queue, so we are done here.  */
> > +   count += 2;
> > +   return count;
> > +      }
> >    }
> >  
> >   done:
> 
> I'm still trying to implement this, but after yesterday's commit 2241f7ca7ad,
> compilation fails with
> 
> emacs/src/term.c:2571: undefined reference to `tty_handle_tab_bar_click'
> 
> Not sure why `tty_handle_tab_bar_click' should be defined
> only with HAVE_NTGUI && !CYGWIN.

It was a mistake to do that, and I've reverted that part.  It should
compile for you now.

> What condition should be added to use tty_handle_tab_bar_click in term.c?
> Maybe HAVE_GPM?  Is this change correct?

There should be no condition at all.  This function is needed by any
build that supports the mouse on TTY frames, and that means all the
platforms we support, at least potentially.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]