emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch, review request] better dired-isearch-filenames reset in dire


From: Stefan Monnier
Subject: Re: [patch, review request] better dired-isearch-filenames reset in dired-isearch-filenames-end
Date: Thu, 28 Nov 2019 11:07:21 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

> Current code calls custom-reevaluate-setting (bug#30187), and that
> results in wrong value when dired-isearch-filenames was initialized not
> with emacs customization facility, but with plain setq in .emacs.  I
> think a temporary local variable is a better way to save & restore the
> global setting, WDYT?  In my tests what worked well.

Using custom-reevaluate-setting seems like a bad idea here, indeed.
It's really only meant to update settings that were evaluated "too
early" (i.e. during the dump).


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]