[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 7e387c9: * lisp/man.el (Man-width-max): New defcustom (bug#32

From: Eli Zaretskii
Subject: Re: master 7e387c9: * lisp/man.el (Man-width-max): New defcustom (bug#32536, bug#9385)
Date: Sun, 08 Dec 2019 20:03:59 +0200

> +(defun Man-columns ()
> +  (let ((width (cond
> +                ((and (integerp Man-width) (> Man-width 0))
> +                 Man-width)
> +                (Man-width
> +                 (let ((window (get-buffer-window nil t)))
> +                   (frame-width (and window (window-frame window)))))
> +                (t
> +                 (window-width (get-buffer-window nil t))))))

Bother: both frame-width and window-width return values in units of
the canonical character width, which will not change if the default
face is remapped.  And you are using the value to set the COLUMNS
environment variable, so you could get too wide lines, which will not
fit within the window.

P.S. And please do not "optimize" the log messages the way you did in
this commit: it will make the generated ChangeLog entry look wrong.
Please only use the ChangeLog-style text in the header line of the log
entry if it is the entire text; otherwise please come up with some
summary there, and leave the ChangeLog-style text in its original
form, without an empty line in between.  TIA.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]