[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Change in vc-git ls-files-unknown makes emacs hang

From: Dmitry Gutov
Subject: Re: Change in vc-git ls-files-unknown makes emacs hang
Date: Thu, 19 Dec 2019 16:41:41 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0

Hi Filipp,

On 19.12.2019 16:16, Filipp Gunbin wrote:
Hi, this commit makes Emacs hang and become unusable, this happens when
loading the desktop.  Quitting doesn't unfreeze, so I can't get the
backtrace.  I'm on macOS, tty emacs.

I'm the one who reviewed that patch.

Could you figure out under what circumstances that code (vc-git-dir-status-goto-stage which triggers the freeze) gets called while loading the desktop? In particular, for which directory (but which list of files is passed to vc-git-dir-status-files might also be important). And after you figure that out, does VC-Dir work okay in it?

Since backtrace is hard to get, how about some print-debugging with logging to a file? write-region should help.

UUIC, the only case where this change should lead to a performance problem is a Git repository with lots of unregistered files. Ones not hidden by gitignore.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]